Skip to content

Updated compatibility checker#699

Draft
originalfoo wants to merge 24 commits intomasterfrom
697-608-439-compatibility-checker
Draft

Updated compatibility checker#699
originalfoo wants to merge 24 commits intomasterfrom
697-608-439-compatibility-checker

Conversation

@originalfoo
Copy link
Copy Markdown
Member

@originalfoo originalfoo commented Feb 13, 2020 •
edited
Loading

Work in progress. So far it just logs some stuff to TMPE.log - still got to do all the UI work which will probably take longest.

Once complete....

Fixes #697 :

  • Handle --continuelastsave launch option:
  • > - Turn it off, but remember if it was set
  • > - Only if no compatibility issues found, load last save if applicable
  • Decruft LoadingExtension by moving game version checks to new CompatibilityManager

Fixes #608 :

  • Incompatible mods list moved in to .cs file; old incompatible_mods.txt resource removed
  • Items in list now specify a Severity enum
  • Severity enum allows better decision making:
  • > - Critical items will always be scanned and must be completely unsubscribed
  • > - Major and Minor items only scanned if enabled
  • > - Minor items can be ignored at user discretion
  • Updated mods list logger to include Severity markers and counts
  • Duplicate and zombie assembly detection
  • > - If duplicates are found, user asked to choose which to use
  • > - If zombies are found, user will be notified
  • > - In both cases, exit to desktop required to flush unwanted stuff from RAM
  • More granular error catching and reporting

Fixes #439 :

  • Will exit to desktop (if necessary) after making changes to any mods
  • Disabled mods not scanned by default as Severity enum can be used to override that for Critical conflicts

Fixes #700 :

  • List relevant DLC status in TMPE.log

Updates #724 & UI:

  • Translate the game version warning
  • Mod remover UI (delete vs. disable)
  • Assembly chooser UI
  • Updates to global settings and translations
  • Exit to desktop UI?

Fixes #719 :

  • Include camera scripts in mod checking loop

Fixes #727 :

  • Skip compatibility checks during in-game hot reloads

New incompatible mods added:

Fixes #36
Fixes #149
Fixes #190

@originalfoo
wip - refactoring
57a03f3 
Currently broken, just committing as I've been having lots of power cuts and want to put this somewhere safe.
@originalfoo originalfoo added EXTERNAL Mod conflict or other external factor COMPATIBILITY Mod (in)compatibility / checker labels Feb 13, 2020
@originalfoo originalfoo added this to the 11.2 milestone Feb 13, 2020
@originalfoo originalfoo self-assigned this Feb 13, 2020
@originalfoo
use string builder for logging in loop
ca5b9af
@originalfoo
Now compiles, showing signs of life
d1fefff 
- Successfully prevents launcher continuelastsave
- Mod scanner working (no UI yet)
@originalfoo
Copy link
Copy Markdown
Member Author

originalfoo commented Feb 14, 2020

@krzychu124 - looks like we need to update game version on appveyor or something?

  Compatibility\CompatibilityManager.cs(47,36): error CS0103: The name 'LauncherLoginData' does not exist in the current context [C:\projects\cities-skylines-traffic-manager-president-edition-labs\TLM\TLM\TLM.csproj]
  Compatibility\CompatibilityManager.cs(48,17): error CS0103: The name 'LauncherLoginData' does not exist in the current context [C:\projects\cities-skylines-traffic-manager-president-edition-labs\TLM\TLM\TLM.csproj]

LauncherLoginData class was added in recent launcher update.

@krzychu124
Copy link
Copy Markdown
Member

krzychu124 commented Feb 14, 2020

Yeah, I completely forgot to update dependencies. I will fix it later today 😉

@originalfoo originalfoo modified the milestones: 11.2, 11.1.1 Feb 14, 2020
@originalfoo originalfoo mentioned this pull request Feb 14, 2020
Closed
@originalfoo
Trying to extract version/branch info from assemblies
7d4ec20 
Not having much luck, because I have no idea what I am doing!
@originalfoo
Copy link
Copy Markdown
Member Author

originalfoo commented Feb 15, 2020 •
edited
Loading

IGNORE

Can someone see where I'm going wrong in /Compatibilty/Check/Assemblies.cs, specifically the method at bottom which attempts to extract strings Version and BRANCH from the assembly?

I've never used reflection before so no clue how it really works, despite lots of RTFM I can't see where I'm going wrong.

@originalfoo
Copy link
Copy Markdown
Member Author

originalfoo commented Feb 15, 2020 •
edited
Loading

Oh, wait, I need to pass the class in, not the assembly...? codes...

Nope, still fail.

@originalfoo originalfoo added in-progress The problem is being solved currently Usability Make mod easier to use labels Feb 15, 2020
@originalfoo originalfoo mentioned this pull request Feb 19, 2020
Open
@originalfoo originalfoo added code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability UI User interface updates labels Feb 21, 2020
This was referenced Feb 23, 2020
Open
Merged
kvakvs
kvakvs requested changes Feb 25, 2020
View reviewed changes
Comment thread TLM/TLM/Compatibility/Check/DLCs.cs Outdated
Comment thread TLM/TLM/Compatibility/CompatibilityManager.cs Outdated
Comment thread TLM/TLM/Compatibility/GUI/ProcessIncompatibleMods.cs Outdated
@originalfoo originalfoo modified the milestones: 11.1.1, 11.2 Feb 26, 2020
This was referenced Mar 1, 2020
Merged
Closed
Closed
originalfoo added a commit that referenced this pull request Mar 3, 2020
@originalfoo
Updated call sites to use Prompt
3ad3c5f 
Not updated the `LoadingExtension` because PRs #773 and #699 will be changing it.
@originalfoo originalfoo mentioned this pull request Mar 3, 2020
Merged
3 tasks
@originalfoo originalfoo added ⏸Paused Paused for now and removed in-progress The problem is being solved currently labels Mar 6, 2020
@originalfoo
Copy link
Copy Markdown
Member Author

originalfoo commented Mar 6, 2020

Pausing; going to wait for the form builder that kvakvs is working on before implementing the UI.

@originalfoo originalfoo modified the milestones: 11.2, 11.3 Mar 28, 2020
@originalfoo originalfoo mentioned this pull request Mar 28, 2020
Closed
This was referenced Jan 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvakvs kvakvs kvakvs requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@originalfoo originalfoo

Labels

code cleanup Refactor code, remove old code, improve maintainability COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor ⏸Paused Paused for now technical Tasks that need to be performed in order to improve quality and maintainability UI User interface updates Usability Make mod easier to use

Projects

None yet

Milestone

Not Applicable

3 participants

@originalfoo @krzychu124 @kvakvs